]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
mixer-control: Don't leak ui device
authorGuido Günther <agx@sigxcpu.org>
Wed, 31 Dec 2025 10:55:41 +0000 (11:55 +0100)
committerSimon McVittie <smcv@debian.org>
Mon, 9 Feb 2026 10:10:03 +0000 (10:10 +0000)
We have a ref when creating the `device` object, use that for inserting
into the hash table as otherwise we leak that reference.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Applied-upstream: gnome-shell 49.4, commit:d0e1664ac6278b70a7e26bf8135f0d1d92ee1e9f

Gbp-Pq: Topic libgvc
Gbp-Pq: Name mixer-control-Don-t-leak-ui-device.patch

subprojects/gvc/gvc-mixer-control.c

index 51e389fd55aaba6dc6e5ed98a6a0cb6e406f7ce2..c7f961349686b8d71662e0baf7ba30781d9f9756 100644 (file)
@@ -1367,7 +1367,7 @@ sync_devices (GvcMixerControl *control,
 
                 g_hash_table_insert (is_output ? control->priv->ui_outputs : control->priv->ui_inputs,
                                      GUINT_TO_POINTER (gvc_mixer_ui_device_get_id (device)),
-                                     g_object_ref (device));
+                                     device);
 
                 g_signal_emit (G_OBJECT (control),
                                signals[is_output ? OUTPUT_ADDED : INPUT_ADDED],